Alex Behm has posted comments on this change. Change subject: IMPALA-2809: Improve scalar ByteSwap(). ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/3033/5/be/src/util/bit-util.inline.h File be/src/util/bit-util.inline.h: Line 121: for (int i = 0; i < len; ++i) { For reference I did a micro benchmark of this loop-based swap against C-lib's swab() function, and swab() is about 40% slower than this variant. -- To view, visit http://gerrit.cloudera.org:8080/3033 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f462e6bdb022db46b48889a6a7426120a80d9b4 Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
