Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3532: S3: test_truncate_cleans_hdfs_files fails because we skip INSERT staging ......................................................................
Patch Set 1: > Instead of the small but non-zero loss of test coverage, is it > feasible to to use the value of IS_S3 (from filesystem_utils) to > decide what to check in the asserts? In short, if IS_S3, you look > for 1, 0; else 2, 1. In that case, I've turned off the "s3_skip_insert_staging" option for this test and reset it towards the end, so that the staging directory gets created regardless. -- To view, visit http://gerrit.cloudera.org:8080/3049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3580f03690e29fe99f441b26bc9baa4c0964d79c Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
