Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3532: S3: test_truncate_cleans_hdfs_files fails because we skip INSERT staging ......................................................................
Patch Set 3: > > I've turned off the "s3_skip_insert_staging" option for this test > and reset it towards the end > I didn't mean to imply that you needed to test for the staging > directory on S3, too, just that it seemed good to continue to test > for it the non-S3 cases. I guess this works, then, though if the > test fails too soon then all the S3 INSERTs in subsequent tests on > that connection will produce staging directories. That means > L180-204 have to be wrapped in a try, and L207 in a finally. Makes sense. I've added the try, finally blocks. It doesn't make a huge difference if the option is on or off. The tests will just run faster if it's on. And also it feels like we're adding to many IS_S3 cases, so I wanted to avoid that where possible. -- To view, visit http://gerrit.cloudera.org:8080/3049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3580f03690e29fe99f441b26bc9baa4c0964d79c Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
