Dan Hecht has posted comments on this change. Change subject: IMPALA-3168: replace HashTable parameters with constants ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3088/3/be/src/exec/hash-table.inline.h File be/src/exec/hash-table.inline.h: Line 185: } > It should be initialized to NULL on all paths, either by the caller or the maybe DCHECK(*node != NULL) on entry to document that the caller needs to do that? Line 191: *node = NULL; and then we could remove this. -- To view, visit http://gerrit.cloudera.org:8080/3088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I483a19662c90ca54bc21d60fd6ba97dbed93eaef Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
