Tim Armstrong has posted comments on this change. Change subject: IMPALA-3168: replace HashTable parameters with constants ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3088/3/be/src/exec/hash-table.inline.h File be/src/exec/hash-table.inline.h: Line 185: } > maybe DCHECK(*node != NULL) on entry to document that the caller needs to d It was a little trickier than that, since it sometimes it's call with a pointer to the 'node_' member of an Iterator. In the no-duplicates case, that was initialised to NULL and should never have been modified. I simplified it by just setting it to NULL here if store_duplicates() is false. this is equivalent to the old behaviour, since bucketData.duplicates should always be NULL if no duplicates are stored. node should end up being a local variable anyway, so the dead stores should be optimised out. -- To view, visit http://gerrit.cloudera.org:8080/3088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I483a19662c90ca54bc21d60fd6ba97dbed93eaef Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
