Dan Hecht has posted comments on this change. Change subject: IMPALA-1928: Fix Thrift client transport wrapping order ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3093/1/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 153: transport_ why not just pass socket_ here? do we purposely want transport_ to be socket_ if this call falls? and shouldn't we check the status of this call? -- To view, visit http://gerrit.cloudera.org:8080/3093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d30b3d8d10fe6dcd8eb88cca49734af09f9d91 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
