Dan Hecht has posted comments on this change. Change subject: IMPALA-1928: Fix Thrift client transport wrapping order ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3093/1/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 153: transport_ > I had the same question for Mostafa-- he had said it was to avoid a really Yes, we can deal with it in a follow on change since I guess in the failure case socket_ & transport_ end up with the same values as before. Could you file the JIRA? -- To view, visit http://gerrit.cloudera.org:8080/3093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81d30b3d8d10fe6dcd8eb88cca49734af09f9d91 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
