Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3070
to look at the new patch set (#12).
Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode
......................................................................
IMPALA-3286: prefetching for PartitionedAggregationNode
This patch builds on top of the prefetching infrastructure to add
prefetching to PartitionedAggregationNode. Input batches are evaluated
in prefetch groups and hash table buckets are prefetched if the
prefetch_mode query option is set to HT_BUCKET.
We avoid some pointer indirections on the critical path by caching hash
tables in a 'hash_tbls_' array.
There is also a bit of cleanup to directly instantiate the templated
ProcessBatch() method to remove the ProcessBatch_true() and
ProcessBatch_false() hack, and also to separate out
ProcessBatchNoGrouping() so that it doesn't have to have the same
argument list as ProcessBatch().
TODO: once we finish the PHJ::ProcessProbeBatch() patch I
will do a final pass and make sure that this is consistent.
Co-author: Michael Ho <[email protected]>
Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b
---
M be/src/codegen/gen_ir_descriptions.py
M be/src/exec/hash-table.cc
M be/src/exec/partitioned-aggregation-node-ir.cc
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exec/partitioned-aggregation-node.h
5 files changed, 226 insertions(+), 128 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/70/3070/12
--
To view, visit http://gerrit.cloudera.org:8080/3070
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b
Gerrit-PatchSet: 12
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Mostafa Mokhtar <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
