Michael Ho has posted comments on this change. Change subject: IMPALA-3286: prefetching for PartitionedAggregationNode ......................................................................
Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/3070/13/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: Line 278: if (is_streaming_preagg_) codegen_status = CodegenProcessBatchStreaming(); : else codegen_status = CodegenProcessBatch(); Huh ? These lines lookd weird. Why don't you just do codegen_status = is_streaming_preagg_ ? Codege... : Codegen... Line 331: // There is grouping, so we will do partitioned aggregation. not needed. -- To view, visit http://gerrit.cloudera.org:8080/3070 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7726454efb416d61080c4e11db0ee7ada18c149b Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
