Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-3163: Fix Decimal to Timestamp casting ......................................................................
Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/2791/7//COMMIT_MSG Commit Message: Line 12: I ran a benchmark where we read decimal values from a large parquet > Just to make the old vs. new clearer maybe say something like: Done http://gerrit.cloudera.org:8080/#/c/2791/7/be/src/exprs/decimal-operators-ir.cc File be/src/exprs/decimal-operators-ir.cc: Line 567: int64_t whole_pt = dv.whole_part(scale); > move right above fract_pt for more better 'visual clustering' Done http://gerrit.cloudera.org:8080/#/c/2791/7/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: Line 1351: // IMPALA-3163: From Decimal to Timestamp > // IMPALA-3163: Test precise conversion from Decimal to Timestamp. Done. Originally I wrote the comment that way because other comments looked similar. -- To view, visit http://gerrit.cloudera.org:8080/2791 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9 Gerrit-PatchSet: 7 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Taras Bobrovytsky <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Taras Bobrovytsky <[email protected]> Gerrit-HasComments: Yes
