Hello Alex Behm,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/2791
to look at the new patch set (#9).
Change subject: IMPALA-3163: Fix Decimal to Timestamp casting
......................................................................
IMPALA-3163: Fix Decimal to Timestamp casting
Before this patch, we would first convert the Decimal to Double, then
Double to Timestamp. This resulted in imprecise results.
I ran a benchmark where we read decimal values from a large parquet
table and cast them to timestamp. The new correct implementation is
slightly slower than the old one (96 seconds vs 70 seconds). This issue
can probably be fixed with codegen.
Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9
---
M be/src/exprs/decimal-operators-ir.cc
M be/src/exprs/expr-test.cc
2 files changed, 40 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/91/2791/9
--
To view, visit http://gerrit.cloudera.org:8080/2791
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iabeea9f4ab4880b2f814408add63c77916e2dba9
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Taras Bobrovytsky <[email protected]>
