Tim Armstrong has posted comments on this change. Change subject: IMPALA-3168: replace HashTable parameters with constants ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/3088/8/be/src/exec/partitioned-aggregation-node.cc File be/src/exec/partitioned-aggregation-node.cc: Line 1927: DCHECK_GE(replaced_constants.stores_nulls, 1); > isn't this a function of the hash table itself, ie, couldn't you do this in Dan and I talked about this offline and couldn't come up with a good way to plumb it without a bigger refactoring. The HashTables aren't instantiated in Prepare (since they're part of the Partitions), and in any case the HashTable doesn't directly have access to the HashTableContext's parameters. I think the right solution is to factor out the parameters into a parameter class that can be passed into both. I'll file a JIRA now that I think of it. -- To view, visit http://gerrit.cloudera.org:8080/3088 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I483a19662c90ca54bc21d60fd6ba97dbed93eaef Gerrit-PatchSet: 8 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
