Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/3150
Change subject: IMPALA-3579: Strict handling of numeric overflow in text parsing ...................................................................... IMPALA-3579: Strict handling of numeric overflow in text parsing Adds a query option 'strict_mode' which treats integer and floating pt overflows as parse errors. In the past, overflows were ignored and the max value was returned. When this query option is set, overflowing values are treated as if they were completely invalid data, i.e. NULL is returned. When abort_on_error is enabled, this means the query is aborted. Notes: * DECIMAL overflow/underflow is already treated as an error. * The handling in text-converter treats underflows the same as overflows, so they would result in the same behavior. However, integer and floating point parsing never returns an underflow today. Change-Id: I7409c31ec0cb6fe0b2d9842b9f58fe1670914836 --- M be/src/exec/hdfs-scanner.cc M be/src/exec/hdfs-text-scanner.cc M be/src/exec/text-converter.cc M be/src/exec/text-converter.h M be/src/exec/text-converter.inline.h M be/src/runtime/runtime-state.h M be/src/service/query-options.cc M be/src/service/query-options.h M common/thrift/ImpalaInternalService.thrift M common/thrift/ImpalaService.thrift A testdata/workloads/functional-query/queries/QueryTest/strict-mode-abort.test A testdata/workloads/functional-query/queries/QueryTest/strict-mode.test M tests/query_test/test_queries.py 13 files changed, 129 insertions(+), 17 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/50/3150/1 -- To view, visit http://gerrit.cloudera.org:8080/3150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7409c31ec0cb6fe0b2d9842b9f58fe1670914836 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Matthew Jacobs <[email protected]>
