Dan Hecht has posted comments on this change. Change subject: IMPALA-3579: Strict handling of numeric overflow in text parsing ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3150/2/be/src/exec/text-converter.inline.h File be/src/exec/text-converter.inline.h: Line 172: (strict_mode_ && parse_result == StringParser::PARSE_OVERFLOW)) { this is okay, though the old version was slightly faster: it had only one compare/branch in the case of PARSE_SUCCESS... -- To view, visit http://gerrit.cloudera.org:8080/3150 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7409c31ec0cb6fe0b2d9842b9f58fe1670914836 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
