Jim Apple has posted comments on this change. Change subject: IMPALA-3450: LIMITs on plan nodes are reflected in cardinality estimates ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3127/4/testdata/workloads/functional-planner/queries/PlannerTest/joins.test File testdata/workloads/functional-planner/queries/PlannerTest/joins.test: Line 2202: # IMPALA-3450: limits on nodes are reflected in cardinality estimates. In this test, > Given that we are adding a lot of lines for these tests, I think it makes m Most of the tests won't have inline views anymore once we can check the cardinality limit directly without the need for joins to indirectly detect cardinality. As such, my feeling is that the tests do not then belong in inline-view-limit.test. Thoughts? -- To view, visit http://gerrit.cloudera.org:8080/3127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic06dcb93bbb2510c0d40151302bd817ef340b825 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
