Jim Apple has posted comments on this change.

Change subject: IMPALA-3450: LIMITs on plan nodes are reflected in cardinality 
estimates
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/3127/5/testdata/workloads/functional-planner/queries/PlannerTest/inline-view-limit.test
File 
testdata/workloads/functional-planner/queries/PlannerTest/inline-view-limit.test:

Line 616: # IMPALA-3450: limits on select nodes are reflected in cardinality 
estimates. The test for
> Second test in inline-view-limit.test?
Nope. Something else causes the cardinality estimate on the SELECT node to be 
1, with or without the limit clause.


http://gerrit.cloudera.org:8080/#/c/3127/5/testdata/workloads/functional-planner/queries/PlannerTest/union.test
File testdata/workloads/functional-planner/queries/PlannerTest/union.test:

Line 2664: # IMPALA-3450: limits on union nodes are reflected in cardinality 
estimates. The test for
> Test at L894 in this file?
Nope. In that test, the cardinality estimate for the union with limit is 6, 
while the LIMIT clause says no more than 10.


-- 
To view, visit http://gerrit.cloudera.org:8080/3127
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic06dcb93bbb2510c0d40151302bd817ef340b825
Gerrit-PatchSet: 5
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-HasComments: Yes

Reply via email to