Dan Hecht has posted comments on this change. Change subject: IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING ......................................................................
Patch Set 2: (2 comments) Code change looks good but have questions about the test. http://gerrit.cloudera.org:8080/#/c/3146/2/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: Line 14: FILESYSTEM_PREFIX I don't understand this. If it's an HDFS run, how will FILESYSTEM_PREFIX be S3? Line 15: # bucket. Figure out a way to run all possible combinations of supported filesystems. this comment is confusing because the skip marker also means we skip it in S3 runs. Please reword it to just be straight forward and specific about what it covers rather than talking about what it doesn't cover. -- To view, visit http://gerrit.cloudera.org:8080/3146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13b610eb9efb68c83894786cea862d7eae43aa7 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
