Dan Hecht has posted comments on this change. Change subject: IMPALA-3577, IMPALA-3486: Partitions on multiple filesystems breaks with S3_SKIP_INSERT_STAGING ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/3146/6/tests/query_test/test_multiple_filesystems.py File tests/query_test/test_multiple_filesystems.py: Line 13: And we currently cannot run : # this on Isilon and local as secondary filesystems because we need the data to be : # pre-loaded on those filesystems this probably goes away if you address the comment below about copying to the secondary filesystem. (still we can focus on just enabling for S3 for now). Line 41: os.environ["FILESYSTEM_PREFIX"] = "s3a://" + S3_BUCKET_NAME actually, won't this break other tests running in parallel? I think we're better off not mucking with the environment. Maybe we can just make S3_BUCKET_NAME accessible to the .test file and use that? Line 51: "/test-warehouse/%s.db/" % db_name], shell=False) as we discussed, this seems backwards. we shouldn't have to copy to the default fs (HDFS) but we should need to copy to some unique place on S3. -- To view, visit http://gerrit.cloudera.org:8080/3146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib13b610eb9efb68c83894786cea862d7eae43aa7 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
