Hello Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/3133
to look at the new patch set (#3).
Change subject: IMPALA-3537: Move useHiveColLabels out of GlobalState and into
Analyzer.
......................................................................
IMPALA-3537: Move useHiveColLabels out of GlobalState and into Analyzer.
The bug: The useHiveColLabels flag was set in the Analyzer's global
state, so changes to the labelling scheme incorrectly leaked into
other query blocks, e.g., ancestor blocks. This could affect the colunm
labels of the final query results.
The flag really is a property of a specific query block, and not all
query blocks, so the fix is to make the flag a member of Analyzer.
Change-Id: Ie1e446474e1862c78dffd5192a175e043a1d0e90
---
M fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java
M fe/src/test/java/com/cloudera/impala/analysis/AnalyzeStmtsTest.java
2 files changed, 15 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/33/3133/3
--
To view, visit http://gerrit.cloudera.org:8080/3133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie1e446474e1862c78dffd5192a175e043a1d0e90
Gerrit-PatchSet: 3
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
