Alex Behm has posted comments on this change. Change subject: IMPALA-3537: Move useHiveColLabels out of GlobalState and into Analyzer. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3133/2/fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java File fe/src/main/java/com/cloudera/impala/analysis/Analyzer.java: Line 121: // whether to use Hive's auto-generated column labels > nit: Whether (though I see we're inconsistent about capitalization). I prefer consistency and capitalization also. Done. -- To view, visit http://gerrit.cloudera.org:8080/3133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1e446474e1862c78dffd5192a175e043a1d0e90 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
