Youwei Wang has posted comments on this change. Change subject: IMPALA-3504: current timestamp in UTC, i.e. utc_timestamp() ......................................................................
Patch Set 1: (8 comments) http://gerrit.cloudera.org:8080/#/c/3137/1/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: Line 47: using boost::posix_time::second_clock; > Since all of these are only used once in this file, it doesn't really impro Done Line 823: StringVal TimestampFunctions::UtcTimestamp(FunctionContext* context){ > space before '{' Done Line 824: ptime todayUtc(day_clock::universal_day(), > today_utc Done Line 826: std::string result = to_simple_string(todayUtc); > It seems inefficient to convert the time into a string in the wrong format Done Line 826: std::string result = to_simple_string(todayUtc); > It seems inefficient to convert the time into a string in the wrong format Done Line 830: if ( month_name == "Jan" ) { > extra spaces inside the parentheses, here and below. Done Line 860: > extraneous newlines Done http://gerrit.cloudera.org:8080/#/c/3137/1/common/function-registry/impala_functions.py File common/function-registry/impala_functions.py: Line 225: [['utc_timestamp'], 'STRING', [], '_ZN6impala18TimestampFunctions12UtcTimestampEPN10impala_udf15FunctionContextE'], > A function to get the current timestamp (UTC or not) should return a TIMEST Done -- To view, visit http://gerrit.cloudera.org:8080/3137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bfdb916aeb3a572c66d9dd786e3ea8342030ff0 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
