Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3504: current timestamp in UTC, i.e. utc_timestamp() ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/3137/3/be/src/exprs/timestamp-functions-ir.cc File be/src/exprs/timestamp-functions-ir.cc: Line 820: string result = to_iso_extended_string(second_clock::universal_time()); : result[10] = ' '; //erase 'T' character in the extended ISO representation : StringVal date = StringVal::CopyFrom(context, : reinterpret_cast<const uint8_t*>(result.c_str()), result.size()); : BigIntVal biv = TimestampFunctions::UnixFromString(context, date); > I don't think we'll want to do this. See my previous comment. I think a bet Whoops, this comment should have been removed. Ignore this for the moment. The actual implementation will depend on how we expect this function to behave. The comment above is still relevant. -- To view, visit http://gerrit.cloudera.org:8080/3137 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9bfdb916aeb3a572c66d9dd786e3ea8342030ff0 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Youwei Wang <[email protected]> Gerrit-HasComments: Yes
