Michael Brown has posted comments on this change. Change subject: IMPALA-3501: ee tests: detect build type and support different timeouts based on the same ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3156/2/tests/common/environ.py File tests/common/environ.py: Line 135: LOG.warn('Not enough DWARF info in {0} to determine build type; choosing ' > 1. All other places, too. > What do you think about actually dying, not just warning [in] all places? I had avoided that based on something you said in person in an infra meeting, which amounted to, "This would interrupt my development process because I sometimes change compiler options locally." Now, if you're seeing my approach here and have decided that because this is handled in the end to end tests, and not make_impala.sh (or buildall.sh), that's not going to be an interruption, then I'm OK switching to dying. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/3156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b675c04c54e36d404fd9e5a6cf085fb8d6d0e47 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
