Jim Apple has posted comments on this change. Change subject: IMPALA-3501: ee tests: detect build type and support different timeouts based on the same ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3156/2/tests/common/environ.py File tests/common/environ.py: Line 44: # Try to derive the build type. Assume it's 'latest' by default. > [sorry for multiple replies] I think the right thing to do is actually go a WFM. Line 135: LOG.warn('Not enough DWARF info in {0} to determine build type; choosing ' > > What do you think about actually dying, not just warning [in] all places? I forgot about that. On second thought, I guess warning is the best route here. Sorry about the bum steer. -- To view, visit http://gerrit.cloudera.org:8080/3156 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b675c04c54e36d404fd9e5a6cf085fb8d6d0e47 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Brown <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
