Lars Volker has posted comments on this change. Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService ......................................................................
Patch Set 4: (6 comments) Thanks for the review. Please see PS 6. http://gerrit.cloudera.org:8080/#/c/3202/4/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 1379: fragment_instance_states_[global_fragment_instance_idx] = exec_state; > here it is used locally as an index into fragment_instance_states_ (so mayb Done Line 1513: uint32_t global_fragment_instance_idx = params.global_fragment_instance_idx; > here it's also indexing into fragment_instance_states_. Done http://gerrit.cloudera.org:8080/#/c/3202/4/be/src/service/impala-server.cc File be/src/service/impala-server.cc: Line 1090: << " fragment instance#=" << params.global_fragment_instance_idx > i don't see this being used (read) anywhere other than here and in the erro Done http://gerrit.cloudera.org:8080/#/c/3202/4/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 319: // Parameters for a single execution instance of a particular TPlanFragment > remove; now superseded Done Line 320: // Context of a fragment instance, including its unique id, the total number > how about "execution parameters of a ..." Done Line 331: // Index of this fragment instance across all combined instances in this query. > it looks like this specifically indexes into Coordinator::fragment_instance Done -- To view, visit http://gerrit.cloudera.org:8080/3202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
