Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2550: Clean up RPC structures in ImpalaInternalService ......................................................................
Patch Set 6: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/3202/6/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: Line 428: /// 'instance_state_idx' is the 0-based query-wide ordinal of the fragment instance. fix comment: mention fragment_instance_states_ explicitly http://gerrit.cloudera.org:8080/#/c/3202/6/common/thrift/ImpalaInternalService.thrift File common/thrift/ImpalaInternalService.thrift: Line 330: // Index of this fragment instance across all combined instances in this query, used to i would really just say that this is the instance's index into Coordinator::fragment_instance_states_. outside of that it doesn't have any meaning. Line 456: // required in V1 add comment (refer back to TPlanFragmentInstanceCtx.instance_state_idx; that makes it clear where this comes from) -- To view, visit http://gerrit.cloudera.org:8080/3202 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0659c94f6b80bd7bbe0bd150ce243f9efa9a41ad Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
