Alex Behm has posted comments on this change. Change subject: IMPALA-3092: Set default value to NULL in AvroSchemaConverter ......................................................................
Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/3219/4/testdata/workloads/functional-query/queries/QueryTest/avro-schema-change.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-change.test: Line 38: # IMPALA-3092. Create a table with extra column(added by ALTER TABLE ADD COLUMN) with IMPALA-3092: Create an Avro table without column definitions and add columns via ALTER TABLE. Querying the table should work. Line 40: CREATE EXTERNAL TABLE if NOT EXISTS avro_alter_table_add_new_column ( remove IF NOT EXISTS Line 43: STORED AS avro AVRO (caps) Line 46: ---- QUERY move this into the ---- QUERY block above (and separate the stms by semicolon) Line 58: # Every new columns just added should have NULL filled Every new column http://gerrit.cloudera.org:8080/#/c/3219/4/tests/query_test/test_avro_schema_resolution.py File tests/query_test/test_avro_schema_resolution.py: Line 45: def test_avro_schema_change(self, vector, unique_database): test_avro_schema_changes (plural) and same for the .test file -- To view, visit http://gerrit.cloudera.org:8080/3219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86e9ba1f4329b285ae14ee299365f7291a7410e Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
