Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3092: Set default value to NULL in AvroSchemaConverter ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/3219/5//COMMIT_MSG Commit Message: Line 9: won't : become unqueriable. Double negative. http://gerrit.cloudera.org:8080/#/c/3219/5/testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test File testdata/workloads/functional-query/queries/QueryTest/avro-schema-changes.test: Line 2: ---- QUERY I think its better add the comment you removed from test_avro_stale_schema here. "# Create a table with default fileformat and later change it to avro using # alter sql. The query runs with stale metadata and a warning should be raised. # Invalidating metadata should cause the Avro schema to be properly set upon the # next metadata load." Else, it might be difficult to figure out whats the test is doing wihtout looking at the commit message. -- To view, visit http://gerrit.cloudera.org:8080/3219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib86e9ba1f4329b285ae14ee299365f7291a7410e Gerrit-PatchSet: 5 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
