Tim Armstrong has posted comments on this change. Change subject: Allow compiler to use SSE3 and SSSE3 instructions. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3291/1/be/CMakeLists.txt File be/CMakeLists.txt: Line 29: # -msse3, -mssse3: Enable sse3 and ssse3 compiler intrinsics This is misleading, it enables the intrinsics but also allows the compiler to emit the instructions elsewhere. Maybe "Allow compiler to emit sse3 and ssse3 instructions." I'm not sure if this also implies MMX, SSE and SSE2. An alternative would be to set -march=core2, since that includes the minimum feature-set we'd expect. "Intel Core 2 CPU with 64-bit extensions, MMX, SSE, SSE2, SSE3 and SSSE3 instruction set support." -- To view, visit http://gerrit.cloudera.org:8080/3291 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib045e00b5aa71cc6ef16dbda160bfdc7b765158a Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
