Jim Apple has posted comments on this change.

Change subject: Allow compiler to use SSE3 and SSSE3 instructions.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3291/1/be/CMakeLists.txt
File be/CMakeLists.txt:

Line 29: #  -msse3, -mssse3: Enable sse3 and ssse3 compiler intrinsics
> This is misleading, it enables the intrinsics but also allows the compiler 
Our standard arch setting enables up to SSE2:

    $ g++ -march=x86-64 -dM -E - < /dev/null | egrep "MMX|SSE" | sort
    #define __MMX__ 1
    #define __SSE__ 1
    #define __SSE2__ 1
    #define __SSE2_MATH__ 1
    #define __SSE_MATH__ 1

I changed the comment as you requested.


-- 
To view, visit http://gerrit.cloudera.org:8080/3291
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib045e00b5aa71cc6ef16dbda160bfdc7b765158a
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to