Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3682: Don't retry unrecoverable socket creation errors ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/3317/1/be/src/rpc/thrift-client.cc File be/src/rpc/thrift-client.cc: PS1, Line 36: if (!socket_create_status_.ok()) return socket_create_status_; Any reason to still leave this here now? I can't recall if direct calls to Open() are made. -- To view, visit http://gerrit.cloudera.org:8080/3317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I394be287143eefc79cf22865898b71ca24c41328 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
