Dan Hecht has posted comments on this change. Change subject: IMPALA-3682: Don't retry unrecoverable socket creation errors ......................................................................
Patch Set 1: > Hard to add automated testing, partly because the eventual behavior > hasn't changed, just the number of retries it takes to get there. I > did manually test this with a bad SSL setup, and saw a fast failure > as expected. I've added this to the commit message. Yeah, I can see why testing the old vs new is tough, but do we have an automated test to exercise this path? -- To view, visit http://gerrit.cloudera.org:8080/3317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I394be287143eefc79cf22865898b71ca24c41328 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Henry Robinson <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: No
