Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3606: Fix for Java npe when adding a partition which already exists ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/3324/1//COMMIT_MSG Commit Message: Line 7: IMPALA-3606: Fix for Java npe when adding a partition which already exists In general, try to keep lines in the commit messages less than 80 characters. PS1, Line 7: npe NPE PS1, Line 9: whwn "when" typo PS1, Line 9: npe "A NPE" PS1, Line 10: If either of the conditions are true, a null entry is not added to the TCatalogUpdateResult object. I think it may be better to say than in these cases the fix is to return an empty TCatalogUpdateResult that contains no objects. http://gerrit.cloudera.org:8080/#/c/3324/1/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: PS1, Line 368: If the partition already exists in Hive and "IfNotExists" is true, : // then null is returned This comment does not seem to be accurate now. Can you please update it? PS1, Line 393: If the partition does not exist and : // "IfExists" is true, null is returned. Same comment as above. -- To view, visit http://gerrit.cloudera.org:8080/3324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic829e8580c14ed88adf7a0d1571381526b18a206 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
