Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3606: Fix for Java NPE when trying to add an existing partition ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/3324/2//COMMIT_MSG Commit Message: Line 12: You may want to comment about the existing behavior (e.g. the fact that we swallow the exception) and the reason you didn't add any testing. e.g. "No testing was added as the NPE was never exposed to the user, it was simply caught and ignored." http://gerrit.cloudera.org:8080/#/c/3324/2/fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java File fe/src/main/java/com/cloudera/impala/service/CatalogOpExecutor.java: PS2, Line 369: return with an empty TCatalogUpdateResult object Hm, this is not accurate either. We don't really return anything (see L377), we just don't populate 'response' with a dummy table when 'refreshedTable' is null. PS2, Line 394: with an empty TCatalogUpdateResult : // object Same comment as above. -- To view, visit http://gerrit.cloudera.org:8080/3324 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic829e8580c14ed88adf7a0d1571381526b18a206 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-HasComments: Yes
