Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3223: Removal of non-toolchain builds. ......................................................................
Patch Set 9: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3259/6/CMakeLists.txt File CMakeLists.txt: PS6, Line 81: set_dep_root(AVRO) : set_dep_root(BOOST) : set_dep_root(BREAKPAD) > I just inherited the comment. My interpretation is that the new version of Alright I know this wasn't really related to your change so I'll just leave it be for now :) Thanks for looking into it. http://gerrit.cloudera.org:8080/#/c/3259/9/CMakeLists.txt File CMakeLists.txt: PS9, Line 232: # The environment variable $THRIFT_HOME is set in impala-config.sh : # Make sure it's consistent with $THRIFT_ROOT. : if (NOT ($ENV{THRIFT_HOME} STREQUAL ${THRIFT_ROOT})) : message(FATAL_ERROR "THRIFT_ROOT (${THRIFT_ROOT}) differs from environment " : "variable THRIFT_HOME ($ENV{THRIFT_HOME}).") : endif() this seems harder than just setting it from the env var, but that's fine. I'm not really too worried about this in practice, just avoiding duplication of definitions. Anyway, let's get this in. -- To view, visit http://gerrit.cloudera.org:8080/3259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
