Michael Ho has posted comments on this change. Change subject: IMPALA-3223: Removal of non-toolchain builds. ......................................................................
Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/3259/6/CMakeLists.txt File CMakeLists.txt: PS6, Line 81: # Newer versions of boost (including the version in toolchain) don't build separate : # multithreaded versions (they always are). Make sure to pick those up. : set(Boost_USE_MULTITHREADED OFF) > Then I'm confused about the comment. What does "they always are" mean? I just inherited the comment. My interpretation is that the new version of boost is always multi-threaded out of the box so you don't need to build a separate version which is multi-threaded. It may apply to older version of boost which requires building a separate version which is multi-threaded. http://gerrit.cloudera.org:8080/#/c/3259/6/bin/impala-config.sh File bin/impala-config.sh: PS6, Line 343: THRIFT_HOME > Makes sense we need the environment variable then, thanks. However the THR A new check is added in CMakeList.txt to verify they are the same. This patch doesn't really change how $THRIFT_HOME and $THRIFT_ROOT are related. We have lived with this for a long time and have never seen any real problem with it so I won't be too concerned about it. -- To view, visit http://gerrit.cloudera.org:8080/3259 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I42b60e99fb9caf1294be7ab242856ca3b9a5ab73 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
