Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/2/be/src/util/bloom-filter-test.cc File be/src/util/bloom-filter-test.cc: Line 48: TEST(BloomFilter, Insert) { Can we add some test coverage with AVX2 disabled? I believe there's support in CpuInfo to explicitly disable flags. It's also not 100% clear to me whether we'll get reliable test coverage for the AVX2 path on Jenkins machines, since I've seen before that some of them have AVX2 disabled. I'm not too concerned, but it would be good to rerun the tests locally before merging in case the merge job doesn't run with AVX2. -- To view, visit http://gerrit.cloudera.org:8080/3338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
