Tim Armstrong has posted comments on this change. Change subject: Use AVX2 operations to speedup Bloom filter insert by 10-50%. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3338/2/be/src/util/bloom-filter.h File be/src/util/bloom-filter.h: PS2, Line 184: reinterpret_cast<__m256i*>( This cast violates C's strict aliasing rules since we end up accessing the same memory through different non-char data types. For better or worse we compile with -fno-strict-aliasing, so this won't cause problems, but it would be good to document this assumption in a comment. -- To view, visit http://gerrit.cloudera.org:8080/3338 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fef4f6652876f8fd7e3f0e41431702380418c98 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
