Lars Volker has posted comments on this change. Change subject: IMPALA-3684, IMPALA-3693: Disable core files for breakpad tests ......................................................................
Patch Set 1: (2 comments) Thanks for the review. Tests pass on Jenkins here: http://sandbox.jenkins.cloudera.com/job/impala-umbrella-build-and-test/1576/ 01:55:26.660 custom_cluster/test_breakpad.py ..... http://gerrit.cloudera.org:8080/#/c/3339/1/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS1, Line 57: return > Can you make this something like: Done PS1, Line 63: if cls.exploration_strategy() != 'exhaustive': : return > If you use pytest.skip() as I suggested L57, this block is not needed. Done -- To view, visit http://gerrit.cloudera.org:8080/3339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If592339632aa662b59be09d911229566d5772321 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
