Lars Volker has posted comments on this change. Change subject: IMPALA-3684, IMPALA-3693: Disable core files for breakpad tests ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3339/2/tests/custom_cluster/test_breakpad.py File tests/custom_cluster/test_breakpad.py: PS2, Line 186: self.kill_processes(self.cluster.impalads[:1], SIGSEGV) > I'm curious: why did you choose [:1] instead of [0]? the method takes a list, so I thought this was more clear than [self.c.i[0]] . Should I change it to the latter? -- To view, visit http://gerrit.cloudera.org:8080/3339 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: If592339632aa662b59be09d911229566d5772321 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Lars Volker <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Michael Brown <[email protected]> Gerrit-HasComments: Yes
