Huaisi Xu has posted comments on this change. Change subject: IMPALA-3499: Split catalog update ......................................................................
Patch Set 9: (3 comments) got to go now.. will update the rest and patch at night... http://gerrit.cloudera.org:8080/#/c/3067/9/be/src/util/jni-util.h File be/src/util/jni-util.h: PS9, Line 275: _2D > Not a big fan of this "2D" but I'll leave it up to you and Henry to decide. I just made up something randomly.. I know I am poor at naming things.. :-) PS9, Line 276: args.size(),bytearray_class,NULL > nit: spaces after "," Done PS9, Line 286: jbytearray_2D > Do you know if this copies the bytes? If so, this might be a bit expensive I am not sure. I tried to google this but I could not find anything. AFAIK, it is implementation dependent. Yes that was the behavior previously. I think if we directly pass that NewDirectByteBuffer we can reduce a copy, but we have to call SetObjectArrayElement(), and I think that will make a copy anyway... what do you think? I do not have enough resources now to confirm these.. -- To view, visit http://gerrit.cloudera.org:8080/3067 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928 Gerrit-PatchSet: 9 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
