Henry Robinson has posted comments on this change.

Change subject: IMPALA-3499: Split catalog update
......................................................................


Patch Set 9:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3067/9/be/src/util/jni-util.h
File be/src/util/jni-util.h:

PS9, Line 286: jbytearray_2D
> I am not sure. I tried to google this but I could not find anything. AFAIK,
I don't think SetObjectArrayElement() would copy the bytes - the byte buffer 
contains a pointer to the array, and that's what would be copied.


-- 
To view, visit http://gerrit.cloudera.org:8080/3067
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I176db25124a32944f2396ce8aafbed49cac95928
Gerrit-PatchSet: 9
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Huaisi Xu <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-Reviewer: Henry Robinson <[email protected]>
Gerrit-Reviewer: Huaisi Xu <[email protected]>
Gerrit-HasComments: Yes

Reply via email to