Dan Hecht has posted comments on this change. Change subject: IMPALA-3664: S3A test_keys_do_not_work fails ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3358/3/be/src/runtime/hdfs-fs-cache.cc File be/src/runtime/hdfs-fs-cache.cc: Line 92: // unlikely to change. do you have a link to discussion on that? the Hadoop FileSystem cache code seems broken if it doesn't use the configuration as part of the key. Line 93: hdfsBuilderSetForceNewInstance(hdfs_builder); do we think this will have any perf impact? I guess not since we have our own cache in this module, and so don't really need to rely on the FileSystem.java cache? -- To view, visit http://gerrit.cloudera.org:8080/3358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
