Sailesh Mukil has posted comments on this change. Change subject: IMPALA-3664: S3A test_keys_do_not_work fails ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3358/3/be/src/runtime/hdfs-fs-cache.cc File be/src/runtime/hdfs-fs-cache.cc: Line 92: // unlikely to change. > do you have a link to discussion on that? the Hadoop FileSystem cache code I have a mail thread with the HDFS team where I bring it up with them which I can add you too. But the part about them not fixing it is in a private chat with one of the team members. I'm not sure if we can call it broken per se. It's more like the libhdfs contract requires you to explicitly call hdfsBuilderSetForceNewInstance() every time you make a configuration change (which is not ideal, I understand). Line 93: hdfsBuilderSetForceNewInstance(hdfs_builder); > do we think this will have any perf impact? I guess not since we have our o It shouldn't. This connection will be stored in our hdfs-fs global cache, and all further requests for a connection will use that one connection. -- To view, visit http://gerrit.cloudera.org:8080/3358 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23b541eef747dd62e59390f8cc9ac6e5742ead40 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-HasComments: Yes
