Huaisi Xu has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/3381/2//COMMIT_MSG Commit Message: Line 13: this patch increases the default intial metastore pool size to 10 from typo: initial. Why did you decide to increase this? I have seen connection leak (current connection is >hundreds). does it mean that we never release those connection? if we still have that problem then probably catalog will get stuck as the release is never called. ? http://gerrit.cloudera.org:8080/#/c/3381/2/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java: Line 76: public void release() { Some time I saw connection to be in the hundreds which means this may not be called at all. so we may fail to offer this client back and catalog may stave on client. -- To view, visit http://gerrit.cloudera.org:8080/3381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
