Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-2347: Reuse metastore client connections in Catalog ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/3381/3//COMMIT_MSG Commit Message: PS3, Line 13: 10 You may want to set the load_catalog_in_background to true and measure the time to do a full metadata load before and after this change. Ideally, we should also use something like Jmeter to measure throughput/latency for DDL operations and see if this change has any effect. http://gerrit.cloudera.org:8080/#/c/3381/3/fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java File fe/src/main/java/com/cloudera/impala/catalog/MetaStoreClientPool.java: PS3, Line 50: MetaStoreClient If you're up to it it would be nice if this class implemented the AutoCloseable interface so that then we could use try-with-resources statement. Right now we need to explicitly call release on the finally block. -- To view, visit http://gerrit.cloudera.org:8080/3381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I517c0e1efef2584cd8d34017b33574f2ad69bd52 Gerrit-PatchSet: 3 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
