Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables
......................................................................


Patch Set 1:

(2 comments)

I think generate-schema-statements.py may need to be updated. The data loading 
code allows you to create a kudu table implicitly (build_table_template() gets 
called), and in that case you wouldn't have a DISTRIBUTE BY clause. E.g. it 
looks like functional_kudu.testtbl will break.

http://gerrit.cloudera.org:8080/#/c/3325/1/bin/impala-config.sh
File bin/impala-config.sh:

PS1, Line 240: 0.9.0-RC1
can we bump this to 0.9.0 now that it's released?


PS1, Line 275: SNAPSHOT
Can we update this to 0.9.0 now that it's been released? Is the TODO above 
still relevant?


-- 
To view, visit http://gerrit.cloudera.org:8080/3325
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Casey Ching <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to