Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3650: DISTRIBUTE BY required for managed Kudu tables ......................................................................
Patch Set 1: > (2 comments) > > I think generate-schema-statements.py may need to be updated. The > data loading code allows you to create a kudu table implicitly > (build_table_template() gets called), and in that case you wouldn't > have a DISTRIBUTE BY clause. E.g. it looks like functional_kudu.testtbl > will break. We may want to have a CREATE_KUDU section for testtbl as we do for the others and then disallow the kudu path in build_table_template() for now. It generates this sql: CREATE DATABASE IF NOT EXISTS functional_kudu; CREATE TABLE IF NOT EXISTS functional_kudu.testtbl ( id bigint, name string, zip int) TBLPROPERTIES ( 'kudu.table_name' = 'testtbl', 'storage_handler' = 'com.cloudera.kudu.hive.KuduStorageHandler', 'kudu.master_addresses' = '127.0.0.1:7051', 'kudu.key_columns' = 'id' ); -- To view, visit http://gerrit.cloudera.org:8080/3325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf2660d0c81a30da706c2df568c1cf272203054f Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Casey Ching <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: No
