Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile ......................................................................
IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile We've seen a number of issues that appear to be a race around the RuntimeProfile handling on the coordinator. We don't have a consistent repro and haven't been able to find the root cause of the crashes/hangs, but we have seen a number of stacks from crashes that include the following frames: ... RuntimeProfile::ComputeTimeInProfile RuntimeProfile::UpdateAverage Coordinator::UpdateAverageProfile Coordinator::UpdateFragmentExecStatus ... This patch fixes a case where we iterate over children_ without holding the lock. I can't prove that this causes the hangs but we certainly should fix this regardless. Testing: Passed several exhaustive test runs successfully. Change-Id: Ibb40ebfa2e58ecaa8668d30ad92003fc75483517 --- M be/src/util/runtime-profile.cc 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/97/3397/2 -- To view, visit http://gerrit.cloudera.org:8080/3397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: Ibb40ebfa2e58ecaa8668d30ad92003fc75483517 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]>
