Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile ......................................................................
IMPALA-3757: Add missing lock in RuntimeProfile::ComputeTimeInProfile We've seen a number of issues that appear to be a race around the RuntimeProfile handling on the coordinator. We don't have a consistent repro and haven't been able to find the root cause of the crashes/hangs, but we have seen a number of stacks from crashes that include the following frames: ... RuntimeProfile::ComputeTimeInProfile RuntimeProfile::UpdateAverage Coordinator::UpdateAverageProfile Coordinator::UpdateFragmentExecStatus ... This patch fixes a case where we iterate over children_ without holding the lock. I can't prove that this causes the hangs but we certainly should fix this regardless. Testing: Passed several exhaustive test runs successfully. Change-Id: Ibb40ebfa2e58ecaa8668d30ad92003fc75483517 Reviewed-on: http://gerrit.cloudera.org:8080/3397 Reviewed-by: Matthew Jacobs <[email protected]> Tested-by: Internal Jenkins --- M be/src/util/runtime-profile.cc 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Matthew Jacobs: Looks good to me, approved Internal Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3397 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb40ebfa2e58ecaa8668d30ad92003fc75483517 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Internal Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]>
